Submission Details
Severity:
Host can set deadline unlimited times
Summary
The setDeadline function can be called unlimited times, because of the useless state deadlineSet
Vulnerability Details
Initially, deadlineSet is declared as false:
bool public deadlineSet = false;
In setDeadline function:
function setDeadline(uint256 _days) external onlyHost {
if(deadlineSet) {
revert DeadlineAlreadySet();
} else {
deadline = block.timestamp + _days * 1 days;
emit DeadlineSet(deadline);
}
}
deadlineSet is used but never set to true
Impact
Host can set deadline unlimited times.
Recommendations
Update deadlineSet in setDeadline function:
function setDeadline(uint256 _days) external onlyHost {
if(deadlineSet) {
revert DeadlineAlreadySet();
} else {
+ deadlineSet = true;
deadline = block.timestamp + _days * 1 days;
emit DeadlineSet(deadline);
}
}
Updates
Lead Judging Commences
0xtimefliez 12 months ago
Submission Judgement Published Assigned finding tags:
deadline is never set to true
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.