Submission Details
Severity:
[L-3] State variable `ChristmasDinner::deadlineSet` is never set to true
Description: In the function ChristmasDinner::setDeadline the state variable ChristmasDinner::deadlineSet is never set to true even though it is being checked for in the function and if is true then it should revert by calling error DeadlineAlreadySet.
Impact: The host can change the deadline multiple times
Proof of Concept:
function test_setDeadlineMultipleTimes() public {
vm.startPrank(deployer);
cd.setDeadline(8 days);
cd.setDeadline(10 days);
cd.setDeadline(30 days);
vm.stopPrank();
}
Recommendation: Set the state variable deadlineSet to true in ChristmasDinner::setDeadline
function setDeadline(uint256 _days) external onlyHost {
if(deadlineSet) {
revert DeadlineAlreadySet();
} else {
deadline = block.timestamp + _days * 1 days;
+ deadlineSet = true;
emit DeadlineSet(deadline);
}
}
Updates
Lead Judging Commences
0xtimefliez 10 months ago
Submission Judgement Published Assigned finding tags:
deadline is never set to true
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.