Submission Details
Severity:
depositing Ether doesn't change participation status
Summary
depositing Ether doesn't change participation status
Vulnerability Details
The issues is located on line 255 in ChristmasDinner.sol.
receive() external payable {
etherBalance[msg.sender] += msg.value;
emit NewSignup(msg.sender, msg.value, true);
}
When someone wants to participate in the dinner, but only through depositing Ether, his participation status won't be changed.
Impact
Could lead to not including actual participants in the list, if they don't check and use changeParticipationStatus() themselves.
Tools Used
Manual analysis.
Recommendations
Update the mapping
participant[msg.sender] = true;
when the Ether deposit happens, as with the function deposit(address _token, uint256 _amount).
Updates
Lead Judging Commences
0xtimefliez 7 months ago
Submission Judgement Published Assigned finding tags:
receive does not update participation status
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.