Submission Details
Severity:
Reentrancy guard is implemented incorrectly
Bug description
While there is a nonReentrant modifier, it's implemented incorrectly.:
modifier nonReentrant() {
require(!locked, "No re-entrancy");
_;
locked = false;
}
The lock is always set to false at the end of the function, regardless of its initial state. The correct implementation should set locked = true at the start and locked = false at the end. At this moment the reentrancy guard has no protection at all, therefore all functions with nonReentrant modifier are still vulnerable to reentrancy attacks.
Recommendation
Fix the reentrancy guard:
modifier nonReentrant() {
require(!locked, "No re-entrancy");
locked = true; // Set to true at start
_;
locked = false;
}
Updates
Lead Judging Commences
0xtimefliez 11 months ago
Submission Judgement Published Assigned finding tags:
mutex lock incomplete
Rewards breakdown
nSLOC
129This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.