Summary

The lpTokenDepositValueChange calculation currently lacks sufficient precision. To ensure accurate results, the precision of the computation should be increased.

Vulnerability Details

The calculation for lpTokenDepositValueChange is as follows:

This calculation is not performed using a fixed-point arithmetic approach, making it susceptible to precision loss, especially when the denominator is larger than the numerator—a common scenario.

Impact

Inaccurate lpTokenDepositValueChange calculations can lead to improper fee assessment, potentially disrupting the protocol’s ability to collect fees correctly.

Tools Used

Manual Review

Recommendations

use fixed-point arithmetic