QuantAMM
QuantAMM
49,600 OP
View results
Previous Next
Submission Details
Severity: low
Valid

No Function to Update `UpliftOnlyExample::upliftFeeBps`

mahdirostami

Summary

The contract lacks a function to update the upliftFeeBps variable. Based on its implementation, it seems the protocol intends for upliftFeeBps to be adjustable over time. Evidence supporting this includes:

  • Not Immutable: The upliftFeeBps variable is not declared immutable, implying it is meant to be updated.

  • Update in afterUpdate: The upliftFeeBps value is assigned within the afterUpdate function, indicating an expectation for it to change.

  • HookUpliftWithdrawalFeePercentageChanged event

Recommendations

Introduce a function to allow the owner or an authorized entity to modify upliftFeeBps. This would provide flexibility for adjusting fees as needed by the protocol.

function setUpliftFeeBps(uint64 _upliftFeeBps) external onlyOwner {
upliftFeeBps = _upliftFeeBps;
}
Updates

Lead Judging Commences

n0kto Lead Judge 9 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

invalid_immutable_oracles/variables

Appeal created

n0kto Lead Judge 8 months ago
Submission Judgement Published
Validated
Assigned finding tags:

finding_upliftFeeBps_is_immutable_but_should_be_changeable_according_to_the_sponsor

Likelihood: Low, it cannot be changed but should not need to be changed often. Impact: Low, the code still works with fees.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.