Submission Details
Severity:
Chainlink returned data is not checked for being stale
Summary
There is a call to the Chainlink price feed latestRoundData in the line https://github.com/Cyfrin/2024-12-quantamm/blob/a775db4273eb36e7b4536c5b60207c9f17541b92/pkg/pool-quantamm/contracts/ChainlinkOracle.sol#L29v.It can return a stale price due to Chainlink lagging in delivering actual data.
Impact
Stale prices can result in transactions being excuted at incorrect rates
Recommendations
We recommend adding a call to the price feed function updatedAt to check if the returned data is not stale.
Updates
Lead Judging Commences
n0kto 10 months ago
Submission Judgement Published Reason: Known issue
Assigned finding tags:
invalid_chainlink_staled_data_updateAt_roundId_known_issue
LightChaser: ## [Medium-4] Insufficient oracle validation
Prize pool breakdown
Total prize
49,600 OP
nSLOC
3,00017
OP / LOC
44,640
4,960
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.