Submission Details
Severity:
Constructor in `UpliftOnlyExample.sol` has no checks on parameter setting
Summary
upliftFeeBps and minWithdrawalFeeBps are not checked to be within expected intervals.
Impact
Lack of sanity check may result in redeployment and wasted gas.
constructor(
IVault vault,
IWETH weth,
IPermit2 permit2,
uint64 _upliftFeeBps,
uint64 _minWithdrawalFeeBps,
address _updateWeightRunnerParam,
string memory version,
string memory name,
string memory symbol
) MinimalRouter(vault, weth, permit2, version) Ownable(msg.sender) {
require(bytes(name).length > 0 && bytes(symbol).length > 0, "NAMEREQ");
lpNFT = new LPNFT(name, symbol, address(this));
@> upliftFeeBps = _upliftFeeBps;
@> minWithdrawalFeeBps = _minWithdrawalFeeBps;
_updateWeightRunner = _updateWeightRunnerParam;
Recommendations
Recommend ensuring that both upliftFeeBps and minWithdrawalFeeBps are within [1,10000]
Updates
Lead Judging Commences
n0kto 7 months ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Informational or Gas / Admin is trusted / Pool creation is trusted / User mistake / Suppositions
Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.
Prize pool breakdown
Total prize
49,600 OP
nSLOC
3,00017 OP / LOC
44,640
4,960
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.