QuantAMM

Summary

The MultiHopOracle contract allows an unlimited number of oracle hops to be configured, which could lead to excessive gas costs or transaction failures if too many hops are added. This creates a potential denial of service risk where users may be unable to interact with the protocol due to prohibitively high gas costs.

Vulnerability Details

In the MultiHopOracle contract, there is no limit on the number of oracle hops that can be configured as seen here

The issue arises because each oracle hop:

1. Makes an external call to get price data

2. Performs mathematical calculations to combine the prices

3. Consumes additional gas for loop iteration and storage access

Without an upper bound on _oracles.length, an admin could configure a chain of oracles that:

• Consumes more gas than the block limit

• Makes transactions prohibitively expensive for users

Impact

DOS - Users may be unable to interact with pools that have excessive oracle hops due to transaction failures or prohibitively high gas costs.

Tools Used

Manual Review

Recommendations

Add a maximum limit on the number of oracle hops allowed:

This ensures that:

1. Gas costs remain predictable and reasonable

2. Transactions cannot fail due to excessive oracle hops

3. Admins cannot accidentally or maliciously configure excessive oracle chains