There is no function to change `upliftFeeBps`
Summary
The upliftFeeBps variable in UpliftOnlyExample lacks a setter function, making it immutable after contract deployment despite the implementation suggesting it should be mutable (Storing data in poolsFeeData so that future upliftFeeBps doesn't retroactively affect them)
Vulnerability Details
The contract stores upliftFeeBps in poolsFeeData for each position, indicating an intention to allow fee changes while preserving historical rates for existing positions. However, there is no function to modify the upliftFeeBps state variable after deployment.
Impact
Contract owner cannot adjust uplift fees to respond to market conditions
Contradicts design intention to allow fee modifications
Tools Used
Manual Review
Recommendations
Add an owner-controlled setter function similar to setHookSwapFeePercentage():
Lead Judging Commences
invalid_immutable_oracles/variables
Appeal created
finding_upliftFeeBps_is_immutable_but_should_be_changeable_according_to_the_sponsor
Likelihood: Low, it cannot be changed but should not need to be changed often. Impact: Low, the code still works with fees.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.