QuantAMM

QuantAMM
49,600 OP
View results
Submission Details
Severity: low
Invalid

No check as to whether the arbitrum sequencer is down

Summary

It is stated that the protocol will be deployed on arbitrum, therefore, the sequencer must be checked in the _getData (https://github.com/Cyfrin/2024-12-quantamm/blob/main/pkg/pool-quantamm/contracts/ChainlinkOracle.sol#L24-L33) function or the _getData function (https://github.com/Cyfrin/2024-12-quantamm/blob/main/pkg/pool-quantamm/contracts/UpdateWeightRunner.sol#L347) to ensure that stale price data isn't being used upon the arbitrum sequencer being down.

Vulnerability Details

Note from the chainlink docs page (https://docs.chain.link/data-feeds/using-data-feeds) here:

* If you are reading data feeds on L2 networks, you must
* check the latest answer from the L2 Sequencer Uptime
* Feed to ensure that the data is accurate in the event

This best practise isn't followed.

Impact

Stale prices may be used within the system.

Tools Used

Manual review

Recommendations

Check for sequencer downtime.

Updates

Lead Judging Commences

n0kto Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Known issue
Assigned finding tags:

invalid_sequencer_status_chainlink_and_L2

LightChaser: ## [Medium-6] Missing checks for whether the L2 Sequencer is active ## [Low-22] Chainlink sequencer status is not checked

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!