setQuantAMMSwapFeeTake
function does not validate the lower bound of the _quantAMMSwapFeeTake parameter. As a result, it is possible to set the swap fee to 0, which might unintentionally disable swap fees
The setQuantAMMSwapFeeTake
function allows the _quantAMMSwapFeeTake
value to be set to 0
Setting the swap fee to 0
might:
Result in no revenue from swaps.
Break the economic model if fees are essential.
Manual Review
This ensures the fee is always greater than 0, preventing unintended behavior.
Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.