QuantAMM
QuantAMM
49,600 OP
View results
Previous Next
Submission Details
Severity: low
Invalid

Lack of Input Validation in UpdateWeightRunner.sol::setQuantAMMSwapFeeTake function

hi_there

Summary

setQuantAMMSwapFeeTake function does not validate the lower bound of the _quantAMMSwapFeeTake parameter. As a result, it is possible to set the swap fee to 0, which might unintentionally disable swap fees

Vulnerability Details

The setQuantAMMSwapFeeTake function allows the _quantAMMSwapFeeTake value to be set to 0

Impact

Setting the swap fee to 0 might:

  • Result in no revenue from swaps.

  • Break the economic model if fees are essential.

Tools Used

Manual Review

Recommendations

require(_quantAMMSwapFeeTake > 0, "Swap fee must be greater than 0");

This ensures the fee is always greater than 0, preventing unintended behavior.

Updates

Lead Judging Commences

n0kto Lead Judge 6 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational or Gas / Admin is trusted / Pool creation is trusted / User mistake / Suppositions

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.