Swap and uplift fees can be 100%
Summary
Both setQuantAMMSwapFeeTake and setQuantAMMUpliftFeeTake functions contain a require statement for the fee to be lower than 100%, but the condition lets the fee be 100%.
Vulnerability Details
The following require statement:
States in it's error message string that the fee must be less than 100%, but the condition given allows it to be less than or equal to 100%.
Impact
Swap and upift fees can be set to 100%
Tools Used
Manual review
Recommendations
Cahnge the condition from <= to < in UpdateWeightRunner.sol#L128 and UpdateWeightRunner.sol#L143
Lead Judging Commences
Informational or Gas / Admin is trusted / Pool creation is trusted / User mistake / Suppositions
Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.