Uplift fee setter and getter are setting and getting the wrong state variable.
Summary
The setQuantAMMUpliftFeeTake and getQuantAMMUpliftFeeTake functions are using the swap fee state variable quantAMMSwapFeeTake instead of their own uplift fee state variable.
Impact
Depending on the eventual implementation of the swap fee the use of one variable will make it imposible to configure a separate uplift fee %.
Tools Used
Manual review
Recommendations
Create an uplift fee state variable and implement it in it's setter and getter functions.
Lead Judging Commences
finding_quantAMMSwapFeeTake==quantAMMUplfitFeeTake
Likelyhood: High, calling setters or getters Impact: Low/Medium, both getters return `quantAMMSwapFeeTake` and `setQuantAMMUpliftFeeTake` modify `quantAMMUplfitFeeTake`. Real impact: those 2 values will be always the same.
Prize pool breakdown
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.