QuantAMM
QuantAMM
49,600 OP
View results
Previous Next
Submission Details
Severity: low
Invalid

Unused boolean variable in the `QuantAMMVarianceBasedRule` contract.

saurabh_singh

Summary

Their is a unused boolean variable in the QuantAMMVarianceBasedRule contract.

Vulnerability Details

https://github.com/Cyfrin/2024-12-quantamm/blob/a775db4273eb36e7b4536c5b60207c9f17541b92/pkg/pool-quantamm/contracts/rules/base/QuantammVarianceBasedRule.sol#L17

bool private immutable _protectedAccess;

The above given variable is not used any there in the contract.

As it is a boolean variable, the name suggests that it acts as a flag to protect user access of a function when set to false.

Impact

Not using this flag may allow unauthorized users to access the protected functions.

Tools Used

Manual Review

Recommendations

Use the variable ( flag ) at appropriate place to stop unauthorized access.

Updates

Lead Judging Commences

n0kto Lead Judge 11 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational or Gas / Admin is trusted / Pool creation is trusted / User mistake / Suppositions

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!