QuantAMM
QuantAMM
49,600 OP
View results
Previous Next
Submission Details
Severity: low
Invalid

Lack of reentrancy protection in liquidity functions

ifexx445

Summary

The addLiquidityProportional function and removeLiquidity in UpliftOnlyExample.sol lacks reentrancy protection, which makes it vulnerable to reentrancy attacks. A reentrancy attack could occur if a malicious contract interacts with this function and calls it repeatedly before the state updates are finalized, leading to unintended consequences such as the ability to manipulate the amount of liquidity added or withdraw funds.

Vulnerability Details

function addLiquidityProportional(
address pool,
uint256[] memory maxAmountsIn,
uint256 exactBptAmountOut,
bool wethIsEth,
bytes memory userData
) external payable saveSender(msg.sender) returns (uint256[] memory amountsIn) {
if (poolsFeeData[pool][msg.sender].length > 100) {
revert TooManyDeposits(pool, msg.sender);
}
// Do addLiquidity operation - BPT is minted to this contract.
amountsIn = _addLiquidityProportional(
pool,
msg.sender,
address(this),
maxAmountsIn,
exactBptAmountOut,
wethIsEth,
userData
);
​
uint256 tokenID = lpNFT.mint(msg.sender);
​
//this requires the pool to be registered with the QuantAMM update weight runner
//as well as approved with oracles that provide the prices
uint256 depositValue = getPoolLPTokenValue(
IUpdateWeightRunner(_updateWeightRunner).getData(pool),
pool,
MULDIRECTION.MULDOWN
);

In the code u can see there is a callback used to mint tokens to the user, A a malicious user can craft a contract to exploit this to steal tokens

Impact

Drain of Lp tokens

Tools Used

Manual Audit

Recommendations

Add a reentrancy guard

Updates

Lead Judging Commences

n0kto Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Too generic
Assigned finding tags:

Informational or Gas / Admin is trusted / Pool creation is trusted / User mistake / Suppositions

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!