QuantAMM

Summary

In UpliftOnlyExample.sol there is double division, which could lead to minor, uneccessary precision loss as this precision loss could be mitigated with the same calculation recalculated as a multiplication then division.

Vulnerability Details

Mathematicaly hookFee / (1e18 / quantAMMFeeTake = hookFee * quantAMMFeeTake / 1e18.

In solidity more instances of multiplication and less division reduces unnecessary precision loss, which could make the admin fee slightly lower than anticipated.

Impact

The admin fee may be slightly lower than expected.

Tools Used

Manual review.

Recommendations

Replace the double division with multiplication and division.