QuantAMM

Summary

https://github.com/Cyfrin/2024-12-quantamm/blob/a775db4273eb36e7b4536c5b60207c9f17541b92/pkg/pool-quantamm/contracts/UpdateWeightRunner.sol#L279

The function performUpdate in the provided contract contains error messages that lack sufficient clarity and detail. This may cause difficulties for developers and integrators when debugging or diagnosing issues. While this issue does not directly lead to financial losses or exploits, it can hinder system transparency and usability, potentially delaying resolution of operational errors.

Vulnerability Details

Affected Code:

1. Pool Registration Check:

2. require(rule != address(0), "Pool not registered");

3. The message "Pool not registered" is generic and does not indicate whether the pool address is invalid, uninitialized, or removed from the system.

Tools Used
Manual Review

Recommendations

Improve Error Messages for Better Context:
Provide descriptive messages that include additional information to explain why the condition failed. For example:

• require(_pool != address(0), "Invalid pool address");