QuantAMM

QuantAMM
49,600 OP
View results
Submission Details
Severity: high
Valid

owner fee will be parmanently locked in the contract

Summary

Vulnerability Details

https://github.com/Cyfrin/2024-12-quantamm/blob/a775db4273eb36e7b4536c5b60207c9f17541b92/pkg/pool-hooks/contracts/hooks-quantamm/UpliftOnlyExample.sol#L293

when the swap is been executed the function checks if the quantammfeetake > 0, then it transfers the adminfee from the vault to the quantammadmin and then checks if the are any remaining fee(ownerfee), if there ownerfee is greater than zero the fee is being transferred from the vault the contract address. the issue here is that this contract lacks a way to for owners to withdraw the fee, so the fee will be locked in the contract

Impact

the owner fee will be locked in the contract since the is no way to withdraw the fee

Tools Used

manaul

Recommendations

after the swap the owners fee should be sent to the owners address or the should be a way owners can withdraw the fee

Updates

Lead Judging Commences

n0kto Lead Judge 10 months ago
Submission Judgement Published
Validated
Assigned finding tags:

finding_ownerFee_cannot_be_withdrawn

Likelihood: High, every swap. Impact: High, funds are stuck.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!