Submission Details
Severity:
Dividing followed by multiplying will result in loss of precision.
Summary
There are multiple division-then-multiplication operations in the protocol, which will lead to loss of precision in the calculation results.
Vulnerability Details
In the function DifferenceMomentumUpdateRule.sol#_getWeights, the following code suffers from loss of precision:
locals.newWeights[locals.i] = ONE.div(locals.denominator).mul(locals.newWeights[locals.i]);
if (locals.kappaStore.length == 1) {
locals.normalizationFactor += locals.newWeights[locals.i];
} else {
locals.normalizationFactor += (locals.newWeights[locals.i].mul(locals.kappaStore[locals.i]));
}
This will cause newWeights and normalizationFactor to be smaller than expected.
Impact
loss of precision
Tools Used
VScode
Recommendations
Use the correct order of calculations and avoid dividing before multiplying.
Updates
Lead Judging Commences
n0kto 10 months ago
Submission Judgement Published Reason: Known issue
Assigned finding tags:
invalid_Rules_getWeights_precision_loss_div_mul
## [Low-24] Divide before multiply
Prize pool breakdown
Total prize
49,600 OP
nSLOC
3,00017
OP / LOC
44,640
4,960
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.