Submission Details
Severity:
div before mul
Summary
In the getWeights() function in the contractsChannelFollowingUpdateRule, MomentumUpdateRule, PowerChannelUpdateRule, DifferenceMomentumUpdateRule, the calculation performs division before multiplication, which could result in precision loss.
Vulnerability Details
locals.newWeights[locals.i] = ONE.div(locals.denominator).mul(locals.newWeights[locals.i]);
Impact
Unnecessary precision loss when calculating newWeights
Tools Used
manual
Recommendations
locals.newWeights[locals.i] = ONE.mul(locals.newWeights[locals.i]).div(locals.denominator);
Updates
Lead Judging Commences
n0kto 10 months ago
Submission Judgement Published Reason: Known issue
Assigned finding tags:
invalid_Rules_getWeights_precision_loss_div_mul
## [Low-24] Divide before multiply
Prize pool breakdown
Total prize
49,600 OP
nSLOC
3,00017
OP / LOC
44,640
4,960
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.