QuantAMM
QuantAMM
49,600 OP
View results
Previous Next
Submission Details
Severity: low
Valid

missing implementation for a function to change upliftFee

rzizah

Summary

upliftFeeBps Is the uplift fee in basis points (1/10000) for the pool
the pool creator should have the ability to change this value for future deposits as stated by the sponsor here but there is no function anywhere to do so It is also stated by the sponsor to flag any missing implementation

scenario

pool creator set the upliftFeeBps to 0 as a start then adjust it later then after deployment and some deposits he found out he couldn't change the value

this could be all the way around with fees being too high and not being set back to decent value

Impact

  • function not implemented breaks contract design forcing the creator to static upliftFeeBps

  • loss of (funds / fees) to the creator

Tools Used

manual review

Recommendations

implement a function to change upliftFeeBps

++ function changeUpliftFeeBps(uint256 newUpliftFeeBps) external onlyowner {
++ uint256 oldUpliftFeeBps = upliftFeeBps;
++ require(newUpliftFeeBps <= 10000, "upliftFeeBps must be less than 10000")
++ upliftFeeBps = newUpliftFeeBps;
++ emit upliftFeeBpsChanged(upliftFeeBps,oldUpliftFeeBps)
++ }
Updates

Lead Judging Commences

n0kto Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

invalid_immutable_oracles/variables

Appeal created

rzizah Submitter
10 months ago
n0kto Lead Judge
10 months ago
n0kto Lead Judge 10 months ago
Submission Judgement Published
Validated
Assigned finding tags:

finding_upliftFeeBps_is_immutable_but_should_be_changeable_according_to_the_sponsor

Likelihood: Low, it cannot be changed but should not need to be changed often. Impact: Low, the code still works with fees.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.

Give us feedback!