Submission Details
Severity:
no events emitted in adding liquidity or removing liquidity
Summary
events are crucial for the front end to keep track of successfully deposited amount or withdrawn amounts
there should have been an event with data such ( depositor, BptAmount )
Impact
missing implementation
Tools Used
manual review
Recommendations
emit events when adding or removing liquidity to keep track of data
++ event LiquidityPositionNftMinted(address indexed nftHolder, address indexed pool );
++ LiquidityPositionNftMinted(msg.sender, pool);
and for withdrawal
++ event LiquidityPositionNftBurned(address indexed nftHolder, address indexed pool);
++ emit LiquidityPositionNftBurned(msg.sender, pool);
Updates
Lead Judging Commences
n0kto 10 months ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Informational or Gas / Admin is trusted / Pool creation is trusted / User mistake / Suppositions
Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.
Prize pool breakdown
Total prize
49,600 OP
nSLOC
3,00017
OP / LOC
44,640
4,960
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.