Submission Details
Severity:
wrong value added to blockTimestampDeposit in afterUpdate
Summary
In afterUpdate function the feeDataArray holds blockTimestampDeposit which is the timestamp of when the index of this array has been started
In addLiquidityProportional it hold block.timestamp value but
In afterUpdate it hold block.number
Impact
Function is broken and not working as intended
Tools Used
Manual review
Recommendations
Use block.timestamp
Updates
Lead Judging Commences
n0kto 11 months ago
Submission Judgement Published Assigned finding tags:
finding_afterUpdate_blockNumber_instead_of_timestamp
Likelihood: Medium/High, any NFT transfer will change this variable. Impact: Informational/Very Low. This variable is unused and won’t impact anything, but the array is public and its getter will return a variable with inconsistencies.
Prize pool breakdown
Total prize
49,600 OP
nSLOC
3,00017
OP / LOC
44,640
4,960
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.