Submission Details
Severity:
afterUpdate uses block.number instead of block.timestamp
Summary
The afterUpdate function updates the fee data array information for the token transfered and incorrectly sets
blockTimestampDeposit to the current block number, when this information should be the block timestamp.
Impact
Incorrect information
Tools Used
Manual review
Recommendations
Change block.number to block.timestamp in UpliftOnlyExample.sol#L610
Updates
Lead Judging Commences
n0kto 10 months ago
Submission Judgement Published Assigned finding tags:
finding_afterUpdate_blockNumber_instead_of_timestamp
Likelihood: Medium/High, any NFT transfer will change this variable. Impact: Informational/Very Low. This variable is unused and won’t impact anything, but the array is public and its getter will return a variable with inconsistencies.
Prize pool breakdown
Total prize
49,600 OP
nSLOC
3,00017
OP / LOC
44,640
4,960
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.