QuantAMM

Title

Incorrect Fee Calculation in UpliftOnlyExample.sol

Summary

The onAfterRemoveLiquidity hook in UpliftOnlyExample.sol is responsible for calculating fees, including the uplift fee and admin charges. However, the getQuantAMMUpliftFeeTake() function in this updateWeightRunner.sol incorrectly returns the value of quantAMMSwapFeeTake instead of quantAMMUpliftFeeTake. This results in incorrect fee calculations.

Vulnerability Details

• In the onAfterRemoveLiquidity hook, fees such as upliftFee are calculated using getQuantAMMUpliftFeeTake().

• In the updateWeightRunner, getQuantAMMUpliftFeeTake() wrongly fetches the value of quantAMMSwapFeeTake instead of quantAMMUpliftFeeTake.

• This bug leads to incorrect fee deductions for liquidity removal operations, impacting both users and the protocol.

Impact

1. Incorrect Fee Calculation

Tools Used

• Manual Review

Recommendations

1. Fix Function Logic:

   • Update the setQuantAMMUpliftFeeTake() and getQuantAMMUpliftFeeTake() functions to correctly set and retrieve the value of quantAMMUpliftFeeTake.