QuantAMM
QuantAMM
49,600 OP
View results
Previous Next
Submission Details
Severity: low
Invalid

Integer Overflow/Underflow

ali

Summary

Location: MultiHopOracle.sol (lines 47-51)

The contract performs multiple divisions and multiplications with oracle
data that could potentially overflow or underflow, especially when dealing with large
numbers in price calculations.

Vulnerability Details

Location: MultiHopOracle.sol (lines 47-51)

The contract performs multiple divisions and multiplications with oracle
data that could potentially overflow or underflow, especially when dealing with large
numbers in price calculations.

Code Snippet:

if (oracleConfig.invert) {
data = (data * 10 ** 18) / oracleRes;
} else {
data = (data * oracleRes) / 10 ** 18;
}

Impact

Incorrect calculations leading to fund loss or broken contract logic.

Tools Used

Recommendations

Implement SafeMath operations and add input validation to
ensure oracle values are within acceptable ranges. Consider using a decimal math
library for precise calculations.

Updates

Lead Judging Commences

n0kto Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

Informational or Gas / Admin is trusted / Pool creation is trusted / User mistake / Suppositions

Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.