Submission Details
Severity:
Incorrect parameters were used to emit the `UpdateWeightRunnerAddressUpdated` event in the `QuantAMMWeightedPool::setUpdateWeightRunnerAddress` function
Summary
The UpdateWeightRunnerAddressUpdated event use two input parameters: The old address of UpdateWeightRunner contract and the new address (+), However in QuantAMMWeightedPool::setUpdateWeightRunnerAddress function, both inputs of event are the new contract address.
Recommendations
Save old address of
updateWeightRunnervariable and then allocate new address to it.
function setUpdateWeightRunnerAddress(address _updateWeightRunner) external override {
require(msg.sender == quantammAdmin, "ONLYADMIN");
+ address oldWeightRunner = address(updateWeightRunner);
updateWeightRunner = UpdateWeightRunner(_updateWeightRunner);
- emit UpdateWeightRunnerAddressUpdated(address(updateWeightRunner), _updateWeightRunner);
+ emit UpdateWeightRunnerAddressUpdated(oldWeightRunner, _updateWeightRunner);
}
Updates
Lead Judging Commences
n0kto 10 months ago
Submission Judgement Published Assigned finding tags:
finding_setUpdateWeightRunnerAddress_emit_only_new_address
Likelihood: Low, changing this address is rare. Impact: Low, incorrect event.
Prize pool breakdown
Total prize
49,600 OP
nSLOC
3,00017
OP / LOC
44,640
4,960
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.