QuantAMM

Summary

The validParameters function in AntiMomentumUpdateRule.sol contains a critical validation flaw where it fails to properly validate the denominator type parameter (_parameters[1][0]). The function only validates that values are positive but doesn't enforce the specific requirements for the denominator type parameter, potentially leading to incorrect weight calculations in the pool.

Vulnerability Details

The validParameters() function has insufficient validation logic for its parameters structure:

The function:

1. Checks if _parameters.length is 1 or 2

2. If length is 2, checks if _parameters[1].length == 1

3. Only validates that values in _parameters[0] are positive

4. Does not validate the specific value requirement for _parameters[1][0]

Based on the test file QuantAMMAntiMomentum.t.sol, the parameters should follow this structure:

parameters[1][0] is supposed to be 0 or 1, but in current implementation it can be set to any number.

Tools Used

Manual review

Recommendations

Add validation for parameters[1][0].