QuantAMM

QuantAMM
49,600 OP
View results
Submission Details
Severity: low
Valid

Wrong event emitted in `setUpdateWeightRunnerAddress`

Vulnerability Details

///@dev Emitted when the update weight runner is updated
event UpdateWeightRunnerAddressUpdated(address indexed oldAddress, address indexed newAddress);

setUpdateWeightRunnerAddress is emitting an incorrect event. While emitting the UpdateWeightRunnerAddressUpdated event, it is using the new updateWeightRunner address in place of old address.

function setUpdateWeightRunnerAddress(address _updateWeightRunner) external override {
require(msg.sender == quantammAdmin, "ONLYADMIN");
updateWeightRunner = UpdateWeightRunner(_updateWeightRunner);
@> emit UpdateWeightRunnerAddressUpdated(address(updateWeightRunner), _updateWeightRunner);
}

Recommendations

function setUpdateWeightRunnerAddress(address _updateWeightRunner) external override {
require(msg.sender == quantammAdmin, "ONLYADMIN");
address oldAddress = updateWeightRunner;
updateWeightRunner = UpdateWeightRunner(_updateWeightRunner);
emit UpdateWeightRunnerAddressUpdated(oldAddress, updateWeightRunner);
}
Updates

Lead Judging Commences

n0kto Lead Judge 7 months ago
Submission Judgement Published
Validated
Assigned finding tags:

finding_setUpdateWeightRunnerAddress_emit_only_new_address

Likelihood: Low, changing this address is rare. Impact: Low, incorrect event.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.