Vulnerability Details
event UpdateWeightRunnerAddressUpdated(address indexed oldAddress, address indexed newAddress);
setUpdateWeightRunnerAddress
is emitting an incorrect event. While emitting the UpdateWeightRunnerAddressUpdated
event, it is using the new updateWeightRunner
address in place of old address.
function setUpdateWeightRunnerAddress(address _updateWeightRunner) external override {
require(msg.sender == quantammAdmin, "ONLYADMIN");
updateWeightRunner = UpdateWeightRunner(_updateWeightRunner);
@> emit UpdateWeightRunnerAddressUpdated(address(updateWeightRunner), _updateWeightRunner);
}
Recommendations
function setUpdateWeightRunnerAddress(address _updateWeightRunner) external override {
require(msg.sender == quantammAdmin, "ONLYADMIN");
address oldAddress = updateWeightRunner;
updateWeightRunner = UpdateWeightRunner(_updateWeightRunner);
emit UpdateWeightRunnerAddressUpdated(oldAddress, updateWeightRunner);
}