Submission Details
Severity:
Gas waste by initializing n*n 2d memory array in QuantAMMCovarianceBasedRule
Summary
In QuantAMMCovarianceBasedRule::_setIntermediateCovariance the function initializes a 2d array of size n*n as seen here line 59
int256[][] memory newState = new int256[][]();
newState is meant to be an n by n 2d array for the covariance matrix but is instead initialized as an n*n by n 2d array.
In the case of pools with say 8 tokens , this becomes a 64 by 8 2d array, which leads to significant gas wastage due to solidity's memory expansion costs.
Impact
Low - unnecessary gas waste in an already gas intensive function
Tools Used
Manual Review
Recommendations
Should instead be
int256[][] memory newState = new int256[][]();
Prize pool breakdown
Total prize
49,600 OP
nSLOC
3,00017 OP / LOC
44,640
4,960
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.