QuantAMM

Summary

In the setWeightsManually function, the multiplier can potentially be a negative value, but there is an if statement enforcing that it must be positive. This prevents the multiplier from being set to a negative value when needed.

Vulnerability Details

The setWeightsManually function enforces that the multiplier must always be positive through a validation check. This restriction prevents the multiplier from being configured as negative, which may limit flexibility or conflict with specific use cases.

https://github.com/Cyfrin/2024-12-quantamm/blob/main/pkg/pool-quantamm/contracts/UpdateWeightRunner.sol#L578-L581

Impact

Restricting the multiplier to positive values could cause unintended behavior or prevent certain configurations, potentially reducing the functionality of the system.

Tools Used

Manual Review

Recommendations

Separate the validation logic for multiplier and weight.