Submission Details
Severity:
unused for loop in DifferenceMomentumUpdateRule
Summary
There is a for loop in the DifferenceMomentumUpdateRule that loops over newShortMovingAverages but does nothing as seen here line 90
for (uint i; i < newShortMovingAverages.length; ) {
unchecked {
++i;
}
}
This is unnecessary and can be removed as it leads to unnecessary gas consumption
Impact
Low - unnecessary gas consumption
Tools Used
Manual Review
Recommendations
Remove the for loop
Updates
Lead Judging Commences
n0kto 7 months ago
Submission Judgement Published Reason: Non-acceptable severity
Assigned finding tags:
Informational or Gas / Admin is trusted / Pool creation is trusted / User mistake / Suppositions
Please read the CodeHawks documentation to know which submissions are valid. If you disagree, provide a coded PoC and explain the real likelyhood and the detailed impact on the mainnet without any supposition (if, it could, etc) to prove your point.
Prize pool breakdown
Total prize
49,600 OP
nSLOC
3,00017 OP / LOC
44,640
4,960
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.