QuantAMM

QuantAMM
49,600 OP
View results
Submission Details
Severity: low
Invalid

_baseURI Not Overriden

Summary

In LPNFT OpenZeppelin's ERC721 contract is used as a base. It contains a function _baseURI which by default returns an empty string. The function is not override so it will return the default value. This will mean that every token will return an empty string when the function tokenURI is called. This can be an issue for tracking the different tokens.

Vulnerability Details

tokenURI function is used as an identifier for the different tokens by off-chain services. Not overriding _baseURI means that every token will return the same URI when tokenURI is called - the empty string.

Impact

The LPNFT are unusable by some off-chain services.

Tools Used

Manual Review

Recommendations

Override the _baseURI function and return the name of the token for example. This will make every tokenURI consist of the name concatenated with the tokenId.

Updates

Lead Judging Commences

n0kto Lead Judge 7 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity
Assigned finding tags:

invalid_LPNFT_no_tokenURI

ERC721 Metadata extension is optional in the standard.

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.