HardhatDeFi
15,000 USDC
View results
Submission Details
Severity: low
Valid

Incorrect parameters order

Summary

Incorrect order of parameters in AaveDIVAWrapper.sol constructor from those in AaveDIVAWrapperCore.sol constructor

Vulnerability Details

The constructor in AaveDIVAWrapper.sol:

constructor(address _aaveV3Pool, address _diva, address _owner) AaveDIVAWrapperCore(_aaveV3Pool, _diva, _owner) {}

The constructor in AaveDIVAWrapperCore.sol:

constructor(address diva_, address aaveV3Pool_, address owner_) Ownable(owner_) {

Parameters for diva and aaveV3Pool are in the incorrect order in the AaveDIVAWrapper.sol constructor

Impact

This can cause confusion during deployment and lead to unusable contracts.

Tools Used

Manual review

Recommendations

Change to the correct order

Updates

Lead Judging Commences

bube Lead Judge 7 months ago
Submission Judgement Published
Validated
Assigned finding tags:

Constructor arguments mismatch

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.