Aave DIVA Wrapper

Summary

DOS while doing batch register collateral tokens, if collateral token is already registered

Vulnerability Details

The function batchRegisterCollateralToken is used to register collateral tokens batch wise. This function calls an internal function _registerCollateralToken, where it reverts when the collateral token is already registered. But because of this entire for loop get reverted, and also there is significant amount of gas lose. So, instead of reverting when collateral token is registered, simply return the address of wToken, such that there will be no revert and no problem in for loop too.

Impact

Because collateral token already registered, there will be significant amount of loss (it will be more if the batch collateral tokens length is large).

Tools Used

Manual

Recommendations

Instead of revert when collateral token already registered just return the wToken address