Submission Details
Severity:
Function using iterating array
Summary
Functions like batchAddLiquidity and batchClaimYield iterate over array.
Vulnerability Details
function batchClaimYield(ClaimYieldArgs[] calldata _claimYieldArgs) external override onlyOwner nonReentrant returns (uint256[] memory) {uint256 _length = _claimYieldArgs.length;uint256[] memory _amountsClaimed = new uint256;
for (uint256 i = 0; i < _length; i++) {
_amountsClaimed[i] = _claimYield(_claimYieldArgs[i].collateralToken, _claimYieldArgs[i].recipient);
}
return _amountsClaimed;
}
Impact
If _lengthis very large, it could exceed block gas limits, causing transactions to fail.
Tools Used
Manual Review
Recommendations
Consider adding a limit on array size or implementing chunk-based processing.
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
51929 USDC / LOC
14,000
1,000
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.