Submission Details
Severity:
Wrong parameter order calling to the Core constructor in `AaveDIVAWrapper`
Description:
The contract `AaveDIVAWrapper`, inherits from `AaveDIVAWrapperCore` wich is an abstract contract that handles all the logic of the contract. As it is inheriting of the contract, it should initialize the constructor what is done but the problem is that parameters are beeing passed in a wrong order.
Impact:
The contract won't be util so it will require to re-deploy the contract.
Proof Of Concept:
The `AaveDIVAWrapperCore` contract gets 3 parameters in the constructor:
```
constructor(address diva_, address aaveV3Pool_, address owner_) Ownable(owner_)
```
But in the `AaveDIVAWrapper` we are calling the same constructor in this way:
```
constructor(address _aaveV3Pool, address _diva, address _owner) AaveDIVAWrapperCore(_aaveV3Pool, _diva, _owner)
```
Wich is wrong
Reccomened Mitigation:
Should change the order in wich the constructor parameters are called
```diff
- constructor(address _aaveV3Pool, address _diva, address _owner) AaveDIVAWrapperCore(_aaveV3Pool, _diva, _owner)
+ constructor(address _aaveV3Pool, address _diva, address _owner) AaveDIVAWrapperCore(_diva,_aaveV3Pool, _owner)
```
Updates
Lead Judging Commences
bube 6 months ago
Submission Judgement Published Assigned finding tags:
Constructor arguments mismatch
Prize pool breakdown
Total prize
15,000 USDC
nSLOC
51929 USDC / LOC
14,000
1,000
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.