Aave DIVA Wrapper

Summary

When create contingent pool in the function AaveDIVAWrapperCore::createContingentPool, the contract retrieves the _wToken twice from _collateralTokenToWToken mapping instead of using the already-declared _wToken variable.

This redundant mapping call increases gas costs and reduces code readability, as the _wToken has already been assigned earlier in the function.

Vulnerability Details

In the function AaveDIVAWrapperCore::_createContingentPool, the _wToken is correctly retrieved and stored at the beginning:

However, when calling IDIVA.createContingentPool, the function fetches the same mapping again instead of using _wToken:

Instead, it should directly use _wToken, avoiding unnecessary gas consumption and making the code cleaner.

Impact

Reduces code clarity and wastes unnecessary gas.

Tools Used

Manual review.

Recommendations

Consider using _wToken variable instead of calling _collateralTokenToWToken again.