Aave DIVA Wrapper
DIVA
HardhatDeFi
15,000 USDC
View results
Previous Next
Submission Details
Severity: high
Invalid

The nonReentrant modifier AaveDIVAWrapper.so

hawks

Summary

The AaveDIVAWrapper.sol contract is protected by both the onlyOwner and nonReentrant modifiers. However, onlyOwner is listed before nonReentrant.

) external override onlyOwner nonReentrant returns (address) {
) external override onlyOwner nonReentrant returns (uint256) {
) external override onlyOwner nonReentrant returns (address[] memory) {
) external override onlyOwner nonReentrant returns (uint256[] memory) {

Vulnerability Details

If other modifiers execute before nonReentrant, they might introduce logic that makes the contract vulnerable to reentrancy attacks.

This sequence ensures that the reentrancy protection logic is executed first, guarding against potential state manipulation caused by external calls.

Impact

If other modifiers execute before nonReentrant, they might introduce logic that makes the contract vulnerable to reentrancy attacks. Ensuring nonReentrant is checked first minimizes this risk.

Tools Used

Manual review

Recommendations

Ensuring nonReentrant is checked first minimizes this risk.

Updates

Lead Judging Commences

bube Lead Judge 5 months ago
Submission Judgement Published
Invalidated
Reason: Known issue

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.