Pieces Protocol

First Flight #32
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: medium
Invalid

Ignored Return Values for ERC20 Token Transfers

Description:
Ignoring return values from ERC20 token transfers can lead to undetected failures if the token does not follow the ERC20 standard.

Affected Functions:

  1. TokenDivider.transferErcTokens(...)

  2. TokenDivider.sellErc20(...)

  3. TokenDivider.buyOrder(...)

Impact:

  • ERC20 transfer failures may result in incorrect contract states or fund loss.

Recommendation:

  • Always check return values for IERC20.transfer() and IERC20.transferFrom():

    require(IERC20(token).transfer(to, amount), "Transfer failed");
Updates

Lead Judging Commences

fishy Lead Judge 5 months ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.