Submission Details
Severity:
[L-01] `TokenDivider::onlyNftOwner()` is repeated two times in function `TokenDivider::divideNft()`
Description:
There is no need to repeat the assertion.
function divideNft(
address nftAddress,
uint256 tokenId,
uint256 amount
)
external
@> onlyNftOwner(nftAddress, tokenId)
@> onlyNftOwner(nftAddress, tokenId)
{
if (nftAddress == address(0)) {
revert TokenDivider__NftAddressIsZero();
}
if (amount == 0) {
revert TokenDivider__AmountCantBeZero();
}
ERC20ToGenerateNftFraccion erc20Contract = new ERC20ToGenerateNftFraccion(
string(abi.encodePacked(ERC721(nftAddress).name(), "Fraccion")),
string(abi.encodePacked("F", ERC721(nftAddress).symbol()))
);
erc20Contract.mint(address(this), amount);
address erc20 = address(erc20Contract);
IERC721(nftAddress).safeTransferFrom(
msg.sender,
address(this),
tokenId,
""
);
if (IERC721(nftAddress).ownerOf(tokenId) == msg.sender) {
revert TokenDivider__NftTransferFailed();
}
balances[msg.sender][erc20] = amount;
nftToErc20Info[nftAddress] = ERC20Info({
erc20Address: erc20,
tokenId: tokenId
});
erc20ToMintedAmount[erc20] = amount;
erc20ToNft[erc20] = nftAddress;
emit NftDivided(nftAddress, amount, erc20);
bool transferSuccess = IERC20(erc20).transfer(msg.sender, amount);
if (!transferSuccess) {
revert TokenDivider__TransferFailed();
}
}
Impact:
Low: no functionality is altered. It probably was just a typo.
Recommended Mitigation:
Eliminate one of the assertions:
function divideNft(
address nftAddress,
uint256 tokenId,
uint256 amount
)
external
onlyNftOwner(nftAddress, tokenId)
- onlyNftOwner(nftAddress, tokenId)
{
if (nftAddress == address(0)) {
revert TokenDivider__NftAddressIsZero();
}
Rewards breakdown
nSLOC
181This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.