Submission Details
Severity:
Excess gas in `TokenDivider::divideNft()` function due to repeated modifier
Summary
Excess gas in TokenDivider::divideNft() function due to repeated modifier
Vulnerability Details
The onlyNftOwner()modifier conducts checks that verify that only the owner of an NFT can divide it. But, this modifier is repeated in the same function, thus conducting the checks twice.
Impact
Any gas used to conduct the checks in the first modifier run, is used again. basically wasting gas to run the same checks.
Tools Used
Manual review
Recommendations
Remove the extra modifier as it is practically useless at this point:
function divideNft(address nftAddress, uint256 tokenId, uint256 amount)
external
onlyNftOwner(nftAddress, tokenId)
- onlyNftOwner(nftAddress, tokenId)
{
...
...
}
Updates
Rewards breakdown
nSLOC
181This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.