Submission Details
Severity:
Wrong order of the event TokensTransfered in transferErcTokens function
Summary
The function is reposnible for the transfer of ERC20 tokens associated with a specific NFT (non-fungible token) address.
Vulnerability Details
In the function is wrong order of the event. The event TokensTransferedis before transferFromfunction.
emit TokensTransfered(amount, tokenInfo.erc20Address);
IERC20(tokenInfo.erc20Address).transferFrom(msg.sender,to, amount);
Impact
It might lead to a situation where the event log indicates that a transfer has occurred, even though it may have failed. This can result in misleading records about the state of the contract.
Tools Used
manual review
Recommendations
Please change order
IERC20(tokenInfo.erc20Address).transferFrom(msg.sender,to, amount);
emit TokensTransfered(amount, tokenInfo.erc20Address);
Rewards breakdown
nSLOC
181This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.