Submission Details
Severity:
Duplicate Modifier in divideNft Function
Summary
The divideNft function in the TokenDivider contract has the onlyNftOwner modifier applied twice, which is redundant and wastes gas.
Vulnerability Details
In the divideNft function declaration, the onlyNftOwner modifier is used twice with the same parameters:
function divideNft(address nftAddress, uint256 tokenId, uint256 amount)
onlyNftOwner(nftAddress, tokenId)
onlyNftOwner(nftAddress ,tokenId)
external {
This causes the ownership check to be performed twice unnecessarily.
Impact
Increased gas costs due to redundant checks
Code readability issues
No security impact as the duplicate check doesn't change the function's behavior
Tools Used
Manual code review
Recommendations
Remove one instance of the modifier:
function divideNft(address nftAddress, uint256 tokenId, uint256 amount)
onlyNftOwner(nftAddress, tokenId)
external {
Rewards breakdown
nSLOC
181This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.