Submission Details
Severity:
Redundant Zero Address Check in transferErcTokens Function
Summary
The transferErcTokens function in the contract contains a duplicate check for the zero address of the to parameter, which is unnecessary and wastes gas.
Vulnerability Details
In the transferErcTokens function, there are two identical checks for whether the to address is zero:
if(to == address(0)) {
revert TokenDivider__CantTransferToAddressZero();
}
// ... some code ...
if(to == address(0)) {
revert TokenDivider__CantTransferToAddressZero();
}
The second check is redundant as the first check already ensures that the to address is not zero.
Impact
The duplicate check results in:
Unnecessary gas consumption
Code bloat
Reduced code maintainability
Tools Used
Manual code review
Recommendations
Remove the second zero address check
Rewards breakdown
nSLOC
181This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.