Pieces Protocol

First Flight #32
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: low
Invalid

`TokenDivider::onlyNftOwner` modifier written twice in `TokenDivider::divideNft` function declaration

Description:
In TokenDivider::divideNft function, the onlyNftOwner modifier is written twice, with the same parameters. This adds no additional logic to the function, therefore should be deleted and written only once.

Tools Used:
Manual review

Recommended Mitigation:
The onlyNftOwner modifier should be written only once.

- function divideNft(address nftAddress, uint256 tokenId, uint256 amount) onlyNftOwner(nftAddress, tokenId) onlyNftOwner(nftAddress ,tokenId) external {
+ function divideNft(address nftAddress, uint256 tokenId, uint256 amount) onlyNftOwner(nftAddress ,tokenId) external {
...
}
Updates

Lead Judging Commences

fishy Lead Judge 5 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.