Pieces Protocol

First Flight #32
Beginner FriendlyFoundrySolidityNFT
100 EXP
View results
Submission Details
Severity: high
Valid

Lack of Cancel Functionality for Sell Orders Leads to Potential ERC20 Lock-In

Vulnerability Details

Users can create sell orders using TokenDivider::sellErc20, but there is no mechanism to delete or cancel a sell order once it has been created.
For instance, if a seller creates a sell order with an excessively high price that no other user is willing to pay, the associated ERC20 tokens would remain stuck in the contract unless the seller repurchases them at the high price. Sellers should have the ability to cancel a sell order if they change their mind.

Impact

  • Poor user experience (UX).

  • Potential for ERC20 tokens to become permanently stuck in the contract.

Recommendations

Implement a cancelSellOrder function to allow sellers to remove their sell orders and retrieve their ERC20 tokens.

Updates

Lead Judging Commences

fishy Lead Judge 5 months ago
Submission Judgement Published
Validated
Assigned finding tags:

Sell orders cant be canceled

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.