Submission Details
Severity:
Duplicate zero address check in `transferErcTokens` wastes gas
Summary:
The transferErcTokens function contains an unnecessary duplicate zero address check, wasting gas.
Vulnerability Details:
The transferErcTokens function checks if the to address is equal to the zero address twice, which is unnecessary and results in wasted gas.
Impact:
Repeatedly checking the same condition in the function consumes more gas than necessary, increasing the cost for users and reducing the overall efficiency of the contract.
Tools Used:
Solidity, Foundry.
Recommendations:
Remove the duplicate zero address check in the transferErcTokens function to save gas and improve efficiency.
Example:
function transferErcTokens(address nftAddress, address to, uint256 amount) external {
// First check
if (to == address(0)) {
revert TokenDivider__CantTransferToAddressZero();
}
// ... other checks ...
// Remove duplicate check
// if(to == address(0)) {
// revert TokenDivider__CantTransferToAddressZero();
// }
// ... rest of function
}
Rewards breakdown
nSLOC
181This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.