Submission Details
Severity:
Unnecessary modifier in function
The divideNft function in TokenDivider.solredundantly applies the onlyNftOwnermodifier twice.
Impact:
Having the same modifier applied multiple times can lead to unexpected behavior, such as unnecessary gas consumption.
Found in src/TokenDivider.sol
function divideNft(
address nftAddress,
uint256 tokenId,
uint256 amount
)
external
onlyNftOwner(nftAddress, tokenId)
-> onlyNftOwner(nftAddress, tokenId)
{
if (nftAddress == address(0)) {
revert TokenDivider__NftAddressIsZero();
}
Recommended Mitigation:
Remove the second occurrence of onlyNftOwner to streamline the function.
Rewards breakdown
nSLOC
181This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.